Skip to content

move to platform flags #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fao89 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

move to platform flags #1440

fao89 wants to merge 1 commit into from
+57 −46

Conversation

@fao89
Copy link
Member

@fao89 fao89 commented Dec 18, 2025 •
edited
Loading

Signed-off-by: Fabricio Aguiar fabricio.aguiar@gmail.com

(cherry picked from commit 84e065aab03d7bb7c3638eb6a40f165ada7b78fe)

(#1407 should be backported to 2.6)

@fao89 fao89 requested a review from a team as a code owner December 18, 2025 16:12
zkayyali812
zkayyali812 previously approved these changes Dec 18, 2025
View reviewed changes
@zkayyali812 zkayyali812 dismissed their stale review December 18, 2025 16:16

Failing CI

@zkayyali812
Copy link
Collaborator

zkayyali812 commented Dec 18, 2025 •
edited
Loading

@fao89 PR looks mostly good, but we appear to be failing lint/CI.
I think we don't need all the changes in the poetry.lock that are brought in, I wonder if those are causing the failures here

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.79%. Comparing base (f25ba27) to head (531673d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tests/integration/test_advisory_lock.py 14.28% 6 Missing ⚠️ 
@@            Coverage Diff             @@
##             main    #1440      +/-   ##
==========================================
- Coverage   94.81%   94.79%   -0.03%     
==========================================
  Files         338      338              
  Lines       20053    20069      +16     
==========================================
+ Hits        19013    19024      +11     
- Misses       1040     1045       +5
Flag Coverage Δ
unit-int-tests-3.11 94.73% <81.25%> (-0.03%) ⬇️
unit-int-tests-3.12 94.79% <81.25%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/settings/core.py 100.00% <ø> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
tests/integration/api/test_feature_flags.py 100.00% <100.00%> (ø)
tests/unit/test_features.py 100.00% <100.00%> (ø)
tests/integration/test_advisory_lock.py 29.72% <14.28%> (-2.53%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fao89
move to platform flags
531673d 
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

(cherry picked from commit 84e065aab03d7bb7c3638eb6a40f165ada7b78fe)
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zkayyali812 zkayyali812 zkayyali812 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fao89 @zkayyali812 @codecov-commenter